Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard CI for react-three-fiber migration #795

Merged
merged 9 commits into from
Oct 11, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Oct 10, 2023

What's new

  • Fixing max heap size for allocation on dashboard unit test.
  • Remove stale use of Hatchback mesh
  • Remove use of mesh for model

TODO:

  • use dashboard resources to target an image to be used for robots
  • use dashboard resources to set scale of such images (meters per pixel)

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

aaronchongth and others added 5 commits October 10, 2023 23:35
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth force-pushed the ci/fix-max-heap-size branch 3 times, most recently from 4c2e00e to 37e69b9 Compare October 11, 2023 09:17
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth changed the title Set max heap size Fix dashboard CI for react-three-fiber migration Oct 11, 2023
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #795 (7a07282) into feature/port-three-fiber-branch (794456f) will decrease coverage by 1.28%.
Report is 2 commits behind head on feature/port-three-fiber-branch.
The diff coverage is 0.00%.

@@                         Coverage Diff                         @@
##           feature/port-three-fiber-branch     #795      +/-   ##
===================================================================
- Coverage                            53.25%   51.98%   -1.28%     
===================================================================
  Files                                  272      276       +4     
  Lines                                 6767     6921     +154     
  Branches                               885      920      +35     
===================================================================
- Hits                                  3604     3598       -6     
- Misses                                3020     3183     +163     
+ Partials                               143      140       -3     
Flag Coverage Δ
dashboard 16.89% <0.00%> (-1.56%) ⬇️
react-components 48.17% <0.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...shboard/src/components/three-fiber/robot-three.tsx 0.00% <0.00%> (ø)
...mponents/lib/map/three-fiber/robot-three-maker.tsx 11.11% <0.00%> (+2.53%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
LGTM!

@aaronchongth aaronchongth merged commit b584399 into feature/port-three-fiber-branch Oct 11, 2023
4 checks passed
@aaronchongth aaronchongth deleted the ci/fix-max-heap-size branch October 11, 2023 14:13
aaronchongth added a commit that referenced this pull request Oct 11, 2023
* Add react three fiber and drei

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Use component property in Box material ui component to avoid three Box component noise

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Use component property in Box material ui component to avoid three Box component noise

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Use component property in Box material ui component to avoid three Box component noise

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Export function

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add wall draw calculation

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add reac three fiber logical

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Migrate to react three fiber

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove center state

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove map setting

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Make circle shape smaller

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add zindex to for the text layers to appear on top

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Ensure that React doesn't attempt to create or update component

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add text rendering

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Rendering labels

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Hover and zoom text

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Show labesl correctly

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove unused imports

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Implementing debounce to show labels with delay

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Small fixes to react-three-fiber migration (#788)

* Disable walls

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useLoader with url only, catch CORS errors potentially due to timeout issues when images are large

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Add labels for elevator and door names

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Wrap checkboxes into a div and use select to choose levels

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add zoom icon

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add levelselect event to persits between tabs

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Using AppEvents to persits levels

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Camera control component has been added

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Zoom in and zoom out events

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add camera control component

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add a wheel function to test event

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Expose debounce function

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add wheel function to get the zoom value

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Updating zoom properly

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove conditional useLoader

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove zoom icon

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove zoom implementation

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Fix lint

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Rewrite debounce functino

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add layers for pickup and dropoff waypoints

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Fix dashboard CI for react-three-fiber migration (#795)

* Set max heap size

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Stop producing sourcemap for CI

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* max space to ci

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Try build without sourcemap for CI, alongside heap size increment

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Increasing heapsize on bootstrap step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use experimental support for ECMAScript modules

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use react-components as a module instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Remove use of meshes for robot icons

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert module call

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Co-authored-by: angatupyry <fierrofenix@gmail.com>

* Add spaces in layer names

Signed-off-by: angatupyry <fierrofenix@gmail.com>

---------

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Co-authored-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants